Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amp-story] Refactor pagination buttons to use store service #19600

Closed
Enriqe opened this issue Dec 3, 2018 · 0 comments
Closed

[amp-story] Refactor pagination buttons to use store service #19600

Enriqe opened this issue Dec 3, 2018 · 0 comments
Assignees
@Enriqe
Labels
WG: stories
Projects
Stories - By Type
Milestone
Pending Triage

Comments

@Enriqe
Copy link
Contributor

Enriqe commented Dec 3, 2018 •
edited

Right now the pagination buttons are laid out from the onNavigationStateChange method, which depending on a set of states updates the buttons.

The current state is problematic because it relies on previous states. But really they should be deterministic for any given state, independent of any previous states.
@Enriqe Enriqe self-assigned this Dec 3, 2018
@Enriqe Enriqe added this to Incoming (Untriaged) in Stories - By Type via automation Dec 3, 2018
@Enriqe Enriqe mentioned this issue Dec 3, 2018
Merged
@ampprojectbot ampprojectbot added this to the Pending Triage milestone Dec 5, 2018
@Enriqe Enriqe mentioned this issue Dec 5, 2018
Merged
Stories - By Type automation moved this from Incoming (Untriaged) to Done Dec 11, 2018
@Enriqe Enriqe mentioned this issue Feb 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Enriqe Enriqe

Labels
WG: stories
Projects
Stories - By Type
  
Done
Milestone
Pending Triage
Development

No branches or pull requests
2 participants
@Enriqe @ampprojectbot