[amp-story] Refactor pagination buttons to use store ♻️ #19655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
changed the title
|
Actually I think I'll split this into two PRs. I'll let you know when it's ready for review. |
Enriqe
changed the title
Enriqe
changed the title
Enriqe
force-pushed
the
pagination-btns
branch
3 times, most recently
from
5f3d646
to
2eced2e
Compare
gmajoulet
reviewed
Dec 10, 2018
gmajoulet
approved these changes
Dec 10, 2018
| </amp-story-grid-layer> | ||
| </amp-story-page> | ||
|
|
||
|
|
| @@ -690,12 +690,10 @@ export class AmpStory extends AMP.BaseElement { | |||
| return; | |||
| } | |||
|
|
|||
| this.paginationButtons_ = PaginationButtons.create(this.win); | |||
| this.paginationButtons_ = | |||
| PaginationButtons.create(this.win, () => this.hasBookend_()); | |||
There was a problem hiding this comment.
Plz add a TODO so we find a way to avoid passing a private function here. I understand that it's way out of the scope of this PR, and is already something we do in other places
|
Percy LGTM |
Enriqe
force-pushed
the
pagination-btns
branch
from
20aaecb
to
1701584
Compare
|
Rebased from master to get a green build. Please review Percy again and if it looks good then it's ready to merge :) |
newmuis
approved these changes
Dec 11, 2018
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…9655) * move pagination buttons to use store * ensure buttons work with bookend history state * add visual tests * update pr * reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19600
Make pagination buttons use
AmpStoryStoreServiceinstead ofNavigationState. Also adds visual tests for pagination buttons (only desktop).Follow up PRs will be made to eventually deprecate navigation state. (#19751)