Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for amp-analytics rendered inside A4A #19675

Closed
lannka opened this issue Dec 5, 2018 · 0 comments · Fixed by #19698
Closed

Add integration test for amp-analytics rendered inside A4A #19675

lannka opened this issue Dec 5, 2018 · 0 comments · Fixed by #19698
Assignees
@lannka
Labels
P2: Soon WG: monetization
Projects
Ads+Analytics Fixit Dec 2018

Comments

@lannka
Copy link
Contributor

lannka commented Dec 5, 2018 •
edited

To make sure the macros are correctly scoped.
@lannka lannka self-assigned this Dec 5, 2018
@lannka lannka added this to To do in Ads+Analytics Fixit Dec 2018 via automation Dec 5, 2018
@lannka lannka moved this from To do to In progress in Ads+Analytics Fixit Dec 2018 Dec 5, 2018
@lannka lannka mentioned this issue Dec 7, 2018
Merged
Ads+Analytics Fixit Dec 2018 automation moved this from In progress to Done Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lannka lannka

Labels
P2: Soon WG: monetization
Projects
No open projects
Ads+Analytics Fixit Dec 2018
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding integration for AMPHTML ads rendered on AMP page (A4A) lannka/amphtml
1 participant
@lannka