Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding integration for AMPHTML ads rendered on AMP page (A4A) #19698

Merged
merged 4 commits into from Dec 7, 2018

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Dec 6, 2018

/cc @keithwrightbos @jonkeller @bradfrizzell FYI this in future should catch regression such as HTML_ATTR macro

closes #19675

Copy link
Contributor

@torch2424 torch2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 😄

@lannka lannka merged commit 33561f5 into ampproject:master Dec 7, 2018
@lannka lannka deleted the a4a-analytics-test branch December 7, 2018 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration test for amp-analytics rendered inside A4A
3 participants