Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amp-story] Remove usage of NavigationState in favor of StoreService #19751

Closed
Enriqe opened this issue Dec 10, 2018 · 0 comments · Fixed by #23110
Closed

[amp-story] Remove usage of NavigationState in favor of StoreService #19751

Enriqe opened this issue Dec 10, 2018 · 0 comments · Fixed by #23110
Assignees
@Enriqe
Labels
P3: When Possible WG: stories
Projects
Stories - By Type Stories - By Effort
Milestone
Pending Triage

Comments

@Enriqe
Copy link
Contributor

Enriqe commented Dec 10, 2018

Now that we have the StoreService, we can replace all usages of NavigationState to use the store instead.

e.g. #19655
@Enriqe Enriqe added this to Incoming (Untriaged) in Stories - By Type via automation Dec 10, 2018
@Enriqe Enriqe mentioned this issue Dec 10, 2018
Merged
@ampprojectbot ampprojectbot added this to the Pending Triage milestone Dec 12, 2018
@Enriqe Enriqe self-assigned this Jan 22, 2019
@newmuis newmuis added this to Untriaged in Stories - By Effort May 13, 2019
@newmuis newmuis moved this from Untriaged to S (<= 2.5 days) in Stories - By Effort May 13, 2019
@Enriqe Enriqe mentioned this issue Jun 28, 2019
Merged
Stories - By Type automation moved this from Incoming (Untriaged) to Done Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Enriqe Enriqe

Labels
P3: When Possible WG: stories
Projects
Stories - By Effort
S (<= 2.5 days)
Stories - By Type
  
Done
Milestone
Pending Triage
Development

Successfully merging a pull request may close this issue.

🚮 Remove navigation state Enriqe/amphtml
2 participants
@Enriqe @ampprojectbot