Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick paywall race condition fix #19753

Closed
dvoytenko opened this issue Dec 10, 2018 · 5 comments
Closed

Cherrypick paywall race condition fix #19753

dvoytenko opened this issue Dec 10, 2018 · 5 comments
Assignees
@rsimha
Labels
Cherry-pick: Experimental Type: Release Used to track AMP releases from canary to production

Comments

@dvoytenko
Copy link
Contributor

PR that you are requesting a cherry pick for:

PR #19733

Release(s) you requesting this cherry pick into:

1812061946500 (canary)

Production Release? NO

Canary release? YES

Why does this issue meet the cherry pick criteria? Be specific.

A significant race condition when deciding on paywall display.

/cc @jpettitt
@cramforce
Copy link
Member

LGTM

@rsimha
Copy link
Contributor

rsimha commented Dec 10, 2018

#19733 has now been cherry-picked to the canary branch: https://github.com/ampproject/amphtml/commits/canary.

I'll post an update here once the branch is tested and a new canary is pushed.

@dreamofabear dreamofabear assigned rsimha and unassigned cramforce and dreamofabear Dec 10, 2018
@dreamofabear dreamofabear added the Type: Release Used to track AMP releases from canary to production label Dec 10, 2018
@rsimha
Copy link
Contributor

rsimha commented Dec 11, 2018 •
edited

This was pushed, tested by @dvoytenko, and released yesterday. I'll post an update when this is promoted to prod.

@rsimha
Copy link
Contributor

rsimha commented Dec 11, 2018

Promoted to prod. Released with https://github.com/ampproject/amphtml/releases/tag/1812102014220

@rsimha rsimha closed this as completed Dec 11, 2018
@rsimha
Copy link
Contributor

rsimha commented Dec 12, 2018

This went into release #19659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsimha rsimha

Labels
Cherry-pick: Experimental Type: Release Used to track AMP releases from canary to production
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cramforce @dvoytenko @dreamofabear @rsimha