Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paywall race condition and display issues #19733

Merged
merged 1 commit into from Dec 9, 2018
Merged

Fix paywall race condition and display issues #19733

merged 1 commit into from Dec 9, 2018

Conversation

dvoytenko
Copy link
Contributor

This fix address two issues:

  1. Race condition which, sometimes, prevented the late-arriving authorization to resolve the grantEntitlement promise.
  2. Ensure that a paywall service can check paywall conditions based on the best (granting) entitlement, not just its own entitlement.

jpettitt
jpettitt approved these changes Dec 8, 2018
View reviewed changes
Copy link
Contributor

@jpettitt jpettitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as it goes but I don't fully understand the underlying race..

@dvoytenko dvoytenko merged commit 08d876d into ampproject:master Dec 9, 2018
@dvoytenko dvoytenko deleted the subs31 branch December 9, 2018 07:13
@dvoytenko dvoytenko changed the title Fix paywall display conditions Fix paywall race condition and display issues Dec 10, 2018
@dvoytenko dvoytenko mentioned this pull request Dec 10, 2018
Closed
rsimha pushed a commit that referenced this pull request Dec 10, 2018
@rsimha
Fix paywall display conditions (#19733)
172870d
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
Fix paywall display conditions (ampproject#19733)
c908572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpettitt jpettitt jpettitt approved these changes

@prateekbh prateekbh Awaiting requested review from prateekbh

Assignees
No one assigned
Labels
cla: yes PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dvoytenko @jpettitt @googlebot @ampprojectbot