Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-bind: "Removed unsafe attribute" for binding attributes #20397

Closed
meistudioli opened this issue Jan 17, 2019 · 3 comments
Closed

amp-bind: "Removed unsafe attribute" for binding attributes #20397

meistudioli opened this issue Jan 17, 2019 · 3 comments

Comments

@meistudioli
Copy link
Contributor

meistudioli commented Jan 17, 2019

To whom it may concern:

I use amp-bind in amp-mustache. It works well before. But console will appear the follow message since today (2019-01-17).

Removed unsafe attribute: [class]="'favStore' + ((favStore['Y2655622939']) ? ' favStore--on' : '')"

Here comes my code.

<amp-list
  layout="fill"
  credentials="include"
  items="."
  src="xxxx">
  <template type="amp-mustache">
    <p class="favStore {{#isFollow}}favStore--on{{/isFollow}}" [class]="'favStore' + ((favStore['Y2655622939']) ? ' favStore--on' : '')"></p>
    <em class="bind-insurce" [text]="favStore['Y2655622939']"></em>
  </template>
</amp-list>

I wonder is this an issue or should I need to avoid to do anything ?

Paul

@aghassemi
Copy link
Contributor

@meistudioli Thanks for the report. Looks like we are wrongly reporting transformed attributes as part of #20285. This should be harmless and things should work as before.

/to @choumx, looks like we should suppress warnings for the amp-bind attributes that get rewritten to data-amp-bind-*

@dreamofabear
Copy link

Yea, this is just an incorrect error message. No changes needed. I'll fix this today.

@dreamofabear dreamofabear changed the title amp-bind occurred "Removed unsafe attribute" message amp-bind: "Removed unsafe attribute" for binding attributes Jan 17, 2019
@meistudioli
Copy link
Contributor Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants