Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Removed unsafe attribute" error for amp-bind within amp-list #20472

Closed
joshcp opened this issue Jan 23, 2019 · 3 comments
Closed

"Removed unsafe attribute" error for amp-bind within amp-list #20472

joshcp opened this issue Jan 23, 2019 · 3 comments

Comments

@joshcp
Copy link

joshcp commented Jan 23, 2019

What's the issue?

We're seeing the console error Removed unsafe attribute: on pages using amp-bind within amp-list. It also appears that this sanitization is hammering performance on physical devices.

amp_removed-unsafe-attr

How do we reproduce the issue?

Example URL: https://amp.luckyvitamin.com/p-2257376-swisse-ultiboost-liver-detox-180-tablet-s

Load the example URL and view errors in the console.

What browsers are affected?

All browsers.

Which AMP version is affected?

We noted this issue in version 1901181700510 and it looks like the issue may be related to #20285 and #20397

@dreamofabear
Copy link

Thanks for the report. This is the same as #20474 and #20397.

It also appears that this sanitization is hammering performance on physical devices.

Investigating this.

@dreamofabear
Copy link

The offending release #20361 has been rolled back -- we'll patch and roll forward tomorrow. Thanks again for the report.

@joshcp
Copy link
Author

joshcp commented Jan 23, 2019

Thanks @choumx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants