Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Diff: Allow running some tests synchronously #20781

Closed
torch2424 opened this issue Feb 11, 2019 · 2 comments
Closed

Visual Diff: Allow running some tests synchronously #20781

torch2424 opened this issue Feb 11, 2019 · 2 comments
Assignees
@torch2424 @danielrozenberg
Labels
Type: Feature Request WG: infra
Milestone
New FRs

Comments

@torch2424
Copy link
Contributor

Feedback from the visual diff workshop

Due to factors such as #20671 , it may be a good idea to allow interactive tests to be run synchronously, in relation to other tests. (only Tests in the same file should be fine imo).
@torch2424 torch2424 mentioned this issue Feb 11, 2019
Merged
@ampprojectbot ampprojectbot added this to the New FRs milestone Feb 13, 2019
@danielrozenberg
Copy link
Member

@torch2424 is this still a feature request? Or did #20783 solve the underlying issue?

@torch2424
Copy link
Contributor Author

Oh I think we can close this 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torch2424 torch2424

@danielrozenberg danielrozenberg

Labels
Type: Feature Request WG: infra
Projects
None yet
Milestone
New FRs
Development

No branches or pull requests
3 participants
@torch2424 @danielrozenberg @ampprojectbot