🏗 Added simple Visual Diff Tests for amp-consent #20783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsent-ui-visual-diff
danielrozenberg
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
Code looks good! I'll let @zhouyx have the final say and approve the Percy build
|
Sorry for the late review. This is awesome! Thank you so much for adding them |
|
Hi @torch2424, this appears to have broken the build, since Can you roll back? |
torch2424
added a commit
that referenced
this pull request
Feb 21, 2019
This reverts commit 30d121b.
torch2424
added a commit
that referenced
this pull request
Feb 21, 2019
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Started writing amp-consent visual diff tests * Finally got this working. Need to split into two PRs * Moved testing code out * Removed the need to go to random subdomain. Now handled by testing suite itself
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…20783)" (ampproject#20999) This reverts commit 30d121b.
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* Started writing amp-consent visual diff tests * Finally got this working. Need to split into two PRs * Moved testing code out * Removed the need to go to random subdomain. Now handled by testing suite itself
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
…20783)" (ampproject#20999) This reverts commit 30d121b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds visual diff tests for a very simple amp-consent use case. Also, this allows requests from the
*.localhostsubdomain, to allow checking the consent from *.localhost domains.Issues / PRs that this process has opened
Per pair programming between @danielrozenberg and I, or just feedback from me
relates to #20671
opens #20780
opens #20781
opens #20782
opens #20785
Example