Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Bank: Send back AMP CORS Headers #20868

Closed
torch2424 opened this issue Feb 14, 2019 · 1 comment · Fixed by #20879
Closed

Request Bank: Send back AMP CORS Headers #20868

torch2424 opened this issue Feb 14, 2019 · 1 comment · Fixed by #20879
Assignees
@torch2424
Labels
Type: Bug WG: infra

Comments

@torch2424
Copy link
Contributor

Was writing request bank test for #20541 , and found that there are not AMP CORS headers sent back by the request bank.

screen shot 2019-02-14 at 11 53 45 am
@torch2424 torch2424 mentioned this issue Feb 14, 2019
Merged
@lannka
Copy link
Contributor

lannka commented Feb 14, 2019

is the test passing with this error msg in browser?
Since you're already on it, please help to improve request-bank. you can follow what has been done in enableCors in app.js

@lannka lannka assigned torch2424 and unassigned lannka Feb 14, 2019
This was referenced Feb 14, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torch2424 torch2424

Labels
Type: Bug WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨Request Bank: Fixed AMP CORs and Multipart form data torch2424/amphtml
2 participants
@torch2424 @lannka