✨Request Bank: Fixed AMP CORs and Multipart form data #20879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
approved these changes
Feb 15, 2019
build-system/amp-cors.js
Outdated
| } | ||
| } | ||
|
|
||
| module.exports = { |
There was a problem hiding this comment.
you can do:
module.exports = enableCors;
and to import
const enableCors = require('./amp-cors');
| }); | ||
| app.use( | ||
| '/request-bank/:bid/deposit/:id/', | ||
| upload.array(), |
There was a problem hiding this comment.
i suppose this is a no-op for non-form POST?
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Fixed AMP CORs and Multipart form data for Request Bank * Made requested changes
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* Fixed AMP CORs and Multipart form data for Request Bank * Made requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20868
closes #20869
relates to #20541
This adds multipart form data parsing into the request body, which AMP Form uses, to the RequestBank Express Middleware, as well as, enables AMP Cors on request bank (which included some refactoring in other places).
Example Requests
These examples are made from just switching around the endpoint of the POST request on the recaptcha example
Submitting to a standard endpoint on the dev server
Depositing to request bank
Withdrawing from request bank