New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change bundlesize reporter to use brotli size #21275
Comments
Switching the calculation should be fairly straightforward by adding amphtml/build-system/tasks/bundle-size.js Lines 46 to 63 in 8833970
However, there will be a period when PRs will have base commits for which we only have the gzipped bundle size. I suppose we can ease into this by initially computing both sizes, and then switching exclusively from gzip to brotli at some point. Assigning to @danielrozenberg. |
My work plan on changing this is as follows:
|
Reverted in #24882 |
Unreverted in #24888 |
The gzip file size is largely irrelevant now, and certain optimizations we make that reduce the size of the gzip output can actually increase the size of the brotli output.
The text was updated successfully, but these errors were encountered: