Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "🏗 Stop reporting gzipped compressed size in the bundle-size task" #24882

Merged
merged 1 commit into from Oct 3, 2019
Merged

Revert "🏗 Stop reporting gzipped compressed size in the bundle-size task" #24882

merged 1 commit into from Oct 3, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Oct 3, 2019 •
edited

Reverts #24418

Reason:

dist-bundle-size.js: Running gulp bundle-size --on_push_build...
514[22:55:01] Using gulpfile ~/build/ampproject/amphtml/gulpfile.js
515[22:55:01] Starting 'bundle-size'...
516[22:55:02] Bundle size (brotli) is 71.78KB
517[22:55:02] Could not store the bundle size
518[22:55:02] Error: 400 Bad Request: POST request to /store must have numeric fields "gzippedBundleSize" and "brotliBundleSize"
519[22:55:02] Finished 'bundle-size' after 640 ms

Reopens #21275

@rsimha
Copy link
Contributor Author

rsimha commented Oct 3, 2019

Force merging to unblock master.

@rsimha rsimha merged commit dd23750 into master Oct 3, 2019
@rsimha rsimha mentioned this pull request Oct 3, 2019
Closed
danielrozenberg added a commit to danielrozenberg/amphtml that referenced this pull request Oct 3, 2019
@danielrozenberg
Revert "Revert "Stop reporting gzipped compressed size in the bundle-…
903ae2c 
…size task (ampproject#24418)" (ampproject#24882)"

This reverts commit dd23750.
danielrozenberg added a commit that referenced this pull request Oct 3, 2019
@danielrozenberg
Revert "Revert "Stop reporting gzipped compressed size in the bundle-…
36bcd35 
…size task (#24418)" (#24882)" (#24888)

This reverts commit dd23750.
@rsimha rsimha deleted the revert-24418-do-not-report-gzip branch February 13, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamofabear dreamofabear Awaiting requested review from dreamofabear

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rsimha @googlebot