I2I: Deprecate attribute cross-origin in favor of crossorigin for remote XHR identity requests.

[hellokoji]

In accordance with the deprecation policy.

With reference to I2I Issue (#18787) and Pull Request (#21107), the attribute cross-origin and crossorigin will both be supported to enable POST based identity on remote XHR requests. This deprecation will remove cross-origin as a valid attribute in favor of crossorigin to align with the standard CORS attribute.

• Allow for at least 2 weeks of open discussion.
• Wait for 3 approvals from core committers.
• Update spec
• Announce change on the mailing list.
• Start warning for pages that might break via the developer console.
• Give developers 6 weeks to apply changes.
• Update validator

[torch2424]

closing this as this was implemented 😄

Feel free to comment if this needs more work.

[honeybadgerdontcare]

@hellokoji Confirming that all the above steps have been completed before approving #21909. It's just been about six weeks for developers to apply, but I don't see any approvals from core committers here and was there an announcement on the mailing list?

[honeybadgerdontcare]

@ampproject/wg-approvers for 3 approvals from core committers.

[honeybadgerdontcare]

@hellokoji please announce to amphtml-announce@googlegroups.com

[dvoytenko]

LGTM from me, but I agree with @honeybadgerdontcare. Let's assign the I2I to @ampproject/wg-approvers from now on.

[dvoytenko]

/to @choumx and @Gregable to provide additional approvals.

[hellokoji]

Apologies, I must have missed this. You're right, this never got announced on the mailing list and never had core committer approval.

I'll send out the announcement on the amphtml-announce@googlegroups.com mailing list.

[hellokoji]

Sent.

[Gregable]

I don't think this change has much to do with wg-caching, other than the fact that it is a (small) literal change to validator rules. Perhaps @cramforce instead for the additional approval.

[dreamofabear]

LGTM

[honeybadgerdontcare]

@Gregable this isn't about wg-caching but instead about getting 3 approvals from wg-approvers which you are a member of. So far Dima and Will approved. You could be the third to move this along.

[hellokoji]

Friendly ping to this thread. Still need 1 more approval from a core-committer.

[cramforce]

Approved

[hellokoji]

Marking closed with #21909 being merged.