✨ Add "crossorigin" attribute to remote xhr elements to attach id token. #21107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: If2c56a3cc32ccfe97efb64572dbaf86fdb1d54d0
Change-Id: If19b962e606828b6efd4308b5870480be1c973e9
hellokoji
changed the title
Change-Id: I8e9410492f018bdbf9702e8cf37e8c1b1a2a9a51
Change-Id: I2f7dea01e553c5a38f6ff3d6c5116d50ea62f438
Change-Id: Iea2f29fc25ba9de982eb1cc4bc3c3d9459c754ee
Change-Id: I6859a879e1bee170627f1c06fd473da0bc3d2fd5
|
/cc @honeybadgerdontcare for validator changes. |
|
Validation looks good. Only consideration would be to put in a deprecation_url to a GitHub issue explaining why it's being deprecated. |
7 tasks
Change-Id: I510c0778a60db259486d55b116961d1173198402
|
Created Issue (#21399) and added it as the |
dreamofabear
approved these changes
Mar 13, 2019
Change-Id: Id301b039be182e4c3f92de3b790357edea21a340
Change-Id: I3b04db719fd41f72475e0686aa71e6dd5a0b43fe
Merged
Gregable
pushed a commit
that referenced
this pull request
Mar 20, 2019
- cl/239414441 Revision bump for #21463 - cl/239234304 Add deprecation warning for manufactured body caused by non-ASCII whitespace. - cl/239228383 Explicitly disallow `<template>` outside the document `<body>`. - cl/239220081 Add a feature test case for a non-amp document. - cl/239050986 Revision bump for #21459 - cl/239048160 Fix corner case of ancestor marker tracking. - cl/238487968 Revision bump for #21107 - cl/238483735 Revision bump for #21264
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…en. (ampproject#21107) * Add "cross-origin" attribute to remote xhr elements to attach id token. Change-Id: If2c56a3cc32ccfe97efb64572dbaf86fdb1d54d0 * Lint. Change-Id: Ia74748cea663883663f0121e4fda9bed0f7b9d8d * Address check-types, and presubmits. Change-Id: If19b962e606828b6efd4308b5870480be1c973e9 * Address PR Comments 1. Change-Id: I8e9410492f018bdbf9702e8cf37e8c1b1a2a9a51 * Fix tests. Change-Id: Iea2f29fc25ba9de982eb1cc4bc3c3d9459c754ee * Update validator rules to support crossorigin. Change-Id: I6859a879e1bee170627f1c06fd473da0bc3d2fd5 * Add deprecation URL and update validator tests. Change-Id: I510c0778a60db259486d55b116961d1173198402 * Address PR Comments 2. Change-Id: Id301b039be182e4c3f92de3b790357edea21a340 * Change serviceForDoc impl to getElementServiceIfAvailableForDoc. Change-Id: I3b04db719fd41f72475e0686aa71e6dd5a0b43fe
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
- cl/239414441 Revision bump for ampproject#21463 - cl/239234304 Add deprecation warning for manufactured body caused by non-ASCII whitespace. - cl/239228383 Explicitly disallow `<template>` outside the document `<body>`. - cl/239220081 Add a feature test case for a non-amp document. - cl/239050986 Revision bump for ampproject#21459 - cl/239048160 Fix corner case of ancestor marker tracking. - cl/238487968 Revision bump for ampproject#21107 - cl/238483735 Revision bump for ampproject#21264
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
…en. (ampproject#21107) * Add "cross-origin" attribute to remote xhr elements to attach id token. Change-Id: If2c56a3cc32ccfe97efb64572dbaf86fdb1d54d0 * Lint. Change-Id: Ia74748cea663883663f0121e4fda9bed0f7b9d8d * Address check-types, and presubmits. Change-Id: If19b962e606828b6efd4308b5870480be1c973e9 * Address PR Comments 1. Change-Id: I8e9410492f018bdbf9702e8cf37e8c1b1a2a9a51 * Fix tests. Change-Id: Iea2f29fc25ba9de982eb1cc4bc3c3d9459c754ee * Update validator rules to support crossorigin. Change-Id: I6859a879e1bee170627f1c06fd473da0bc3d2fd5 * Add deprecation URL and update validator tests. Change-Id: I510c0778a60db259486d55b116961d1173198402 * Address PR Comments 2. Change-Id: Id301b039be182e4c3f92de3b790357edea21a340 * Change serviceForDoc impl to getElementServiceIfAvailableForDoc. Change-Id: I3b04db719fd41f72475e0686aa71e6dd5a0b43fe
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
- cl/239414441 Revision bump for ampproject#21463 - cl/239234304 Add deprecation warning for manufactured body caused by non-ASCII whitespace. - cl/239228383 Explicitly disallow `<template>` outside the document `<body>`. - cl/239220081 Add a feature test case for a non-amp document. - cl/239050986 Revision bump for ampproject#21459 - cl/239048160 Fix corner case of ancestor marker tracking. - cl/238487968 Revision bump for ampproject#21107 - cl/238483735 Revision bump for ampproject#21264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Issue (#18787).
Adds the
cross-originattribute toamp-state,amp-list, andamp-form. Given the presence of this attribute, the remote XHR requests will be transformed into POST requests and attach an identity token provided by theamp-viewer-assistanceextension.@choumx