Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow localizing CTA of AMP story Ad #21491

Closed
Jeshuaviv opened this issue Mar 19, 2019 · 3 comments
Closed

Allow localizing CTA of AMP story Ad #21491

Jeshuaviv opened this issue Mar 19, 2019 · 3 comments
Assignees
@newmuis
Labels
Type: Feature Request WG: monetization WG: stories
Projects
Stories - By Type Stories - By Effort

Comments

@Jeshuaviv
Copy link

What's the issue?

how we can change the lenguage of CTA of an AMP Story ad?

How do we reproduce the issue?

isn't an issue. This is a predefined set of choices. https://www.ampproject.org/docs/ads/story_ads_best_practices#call-to-action-button-text-enum

If this is a feature request you can use this section to point to a prototype/mockup that will help us understand the request.

What browsers are affected?

All browsers

Which AMP version is affected?

/amp-story/1.0
CTA-ampstory-ad
@torch2424
Copy link
Contributor

Triaging to @calebcordry 😄

@newmuis
Copy link
Contributor

newmuis commented Mar 22, 2019

I've actually been handling this; it's not currently possible, but I have #21239 and #21253 out to add this functionality.

@newmuis newmuis assigned newmuis and unassigned calebcordry Mar 22, 2019
@newmuis newmuis changed the title CTA of AMP story Ad Allow localizing CTA of AMP story Ad Mar 22, 2019
@newmuis newmuis added this to Incoming (Untriaged) in Stories - By Type via automation Mar 29, 2019
@newmuis newmuis added this to Untriaged in Stories - By Effort May 13, 2019
@newmuis
Copy link
Contributor

newmuis commented May 13, 2019

Whoops; those have both been merged for several weeks, but I forgot to close this 😅

Let me know if there are any issues!

@newmuis newmuis closed this as completed May 13, 2019
Stories - By Type automation moved this from Incoming (Untriaged) to Done May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@newmuis newmuis

Labels
Type: Feature Request WG: monetization WG: stories
Projects
Stories - By Effort
Untriaged
Stories - By Type
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@torch2424 @newmuis @Jeshuaviv @calebcordry