馃寪 Add ability for amp-story-auto-ads CTA strings to be localized #21253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcordry
approved these changes
Mar 4, 2019
| @@ -0,0 +1,142 @@ | |||
| /** | |||
| * Copyright 2018 The AMP HTML Authors. All Rights Reserved. | |||
|
cc/ @jasti |
gmajoulet
reviewed
Mar 7, 2019
newmuis
force-pushed
the
amp-story-auto-ads-strings
branch
from
6128e0d
to
0bc6cc7
Compare
newmuis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #21239.
Note that this PR does not address the "Ad" attribution label; that will need to come in a followup PR (I missed it when looking for strings that need translation 馃槮)