Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace legacy describe tests with one of describes.{realWin|sandboxed|fakeWin|integration} #24144

Closed
rsimha opened this issue Aug 22, 2019 · 3 comments · Fixed by #34305
Closed

Comments

@rsimha
Copy link
Contributor

rsimha commented Aug 22, 2019

This is part of a larger effort to isolate AMP's tests and prevent global state from leaking across tests. See #24090 (comment) for the discussion that led to this issue being filed.

Related to #24090

@rsimha
Copy link
Contributor Author

rsimha commented Aug 23, 2019

Tagging all TLs to triage / prioritize fixes for the legacy tests in your areas.

@jpettitt @lannka @zhouyx @rsimha @kristoferbaxter @choumx @newmuis

@rsimha rsimha closed this as completed Apr 30, 2020
@rsimha rsimha reopened this Apr 30, 2020
@rsimha
Copy link
Contributor Author

rsimha commented Apr 30, 2020

Bumping this issue because we still have ~150 legacy describe tests that haven't been migrated to describes:

// Test files. TODO(#24144): Fix these and remove from the whitelist.
'ads/google/a4a/shared/test/test-content-recommendation.js',
'ads/google/a4a/shared/test/test-url-builder.js',
'ads/google/a4a/test/test-line-delimited-response-handler.js',
'ads/google/a4a/test/test-traffic-experiments.js',
'ads/google/a4a/test/test-utils.js',
'ads/google/test/test-utils.js',
'extensions/amp-a4a/0.1/test/test-a4a-integration.js',
'extensions/amp-a4a/0.1/test/test-a4a-var-source.js',
'extensions/amp-a4a/0.1/test/test-amp-a4a.js',
'extensions/amp-a4a/0.1/test/test-amp-ad-utils.js',
'extensions/amp-a4a/0.1/test/test-callout-vendors.js',
'extensions/amp-a4a/0.1/test/test-refresh.js',
'extensions/amp-access/0.1/test/test-access-expr.js',
'extensions/amp-access/0.1/test/test-amp-login-done-dialog.js',
'extensions/amp-access/0.1/test/test-jwt.js',
'extensions/amp-ad-exit/0.1/test/filters/test-click-delay.js',
'extensions/amp-ad/0.1/test/test-amp-ad-3p-impl.js',
'extensions/amp-ad/0.1/test/test-amp-ad-custom.js',
'extensions/amp-ad/0.1/test/test-amp-ad-xorigin-iframe-handler.js',
'extensions/amp-addthis/0.1/test/addthis-utils/test-fragment.js',
'extensions/amp-addthis/0.1/test/addthis-utils/test-rot13.js',
'extensions/amp-analytics/0.1/test/test-crc32.js',
'extensions/amp-analytics/0.1/test/test-iframe-transport-client.js',
'extensions/amp-analytics/0.1/test/test-linker-manager.js',
'extensions/amp-analytics/0.1/test/test-linker-reader.js',
'extensions/amp-analytics/0.1/test/test-linker.js',
'extensions/amp-analytics/0.1/test/test-transport-serializers.js',
'extensions/amp-analytics/0.1/test/test-vendors.js',
'extensions/amp-animation/0.1/test/test-css-expr.js',
'extensions/amp-auto-ads/0.1/test/test-attributes.js',
'extensions/amp-base-carousel/0.1/test/test-responsive-attributes.js',
'extensions/amp-bind/0.1/test/test-bind-evaluator.js',
'extensions/amp-bind/0.1/test/test-bind-expression.js',
'extensions/amp-bind/0.1/test/test-bind-validator.js',
'extensions/amp-dynamic-css-classes/0.1/test/test-dynamic-classes.js',
'extensions/amp-form/0.1/test/test-form-submit-service.js',
'extensions/amp-fx-collection/0.1/test/integration/test-amp-fx-fly-in.js',
'extensions/amp-lightbox-gallery/0.1/test/integration/test-amp-lightbox-gallery.js',
'extensions/amp-list/0.1/test/integration/test-amp-list.js',
'extensions/amp-live-list/0.1/test/test-poller.js',
'extensions/amp-next-page/0.1/test/test-config.js',
'extensions/amp-script/0.1/test/unit/test-amp-script.js',
'extensions/amp-sidebar/0.1/test/test-toolbar.js',
'extensions/amp-truncate-text/0.1/test/test-binary-search.js',
'extensions/amp-viewer-integration/0.1/test/test-findtext.js',
'test/integration/test-3p-nameframe.js',
'test/integration/test-amp-ad-3p.js',
'test/integration/test-amp-ad-fake.js',
'test/integration/test-amp-analytics.js',
'test/integration/test-amp-pixel.js',
'test/integration/test-amp-skimlinks.js',
'test/integration/test-amphtml-ads.js',
'test/integration/test-boilerplates.js',
'test/integration/test-configuration.js',
'test/integration/test-video-manager.js',
'test/integration/test-video-players.js',
'test/unit/3p/test-3p-messaging.js',
'test/unit/3p/test-recaptcha.js',
'test/unit/ads/test-unruly.js',
'test/unit/test-3p-environment.js',
'test/unit/test-3p.js',
'test/unit/test-action.js',
'test/unit/test-activity.js',
'test/unit/test-ad-helper.js',
'test/unit/test-ads-config.js',
'test/unit/test-alp-handler.js',
'test/unit/test-amp-context.js',
'test/unit/test-amp-img.js',
'test/unit/test-amp-inabox.js',
'test/unit/test-animation.js',
'test/unit/test-batched-json.js',
'test/unit/test-chunk.js',
'test/unit/test-cid.js',
'test/unit/test-css.js',
'test/unit/test-curve.js',
'test/unit/test-describes.js',
'test/unit/test-document-ready.js',
'test/unit/test-element-service.js',
'test/unit/test-error.js',
'test/unit/test-event-helper.js',
'test/unit/test-experiments.js',
'test/unit/test-exponential-backoff.js',
'test/unit/test-finite-state-machine.js',
'test/unit/test-focus-history.js',
'test/unit/test-gesture-recognizers.js',
'test/unit/test-gesture.js',
'test/unit/test-get-html.js',
'test/unit/test-ie-media-bug.js',
'test/unit/test-impression.js',
'test/unit/test-input.js',
'test/unit/test-integration.js',
'test/unit/test-intersection-observer-polyfill.js',
'test/unit/test-intersection-observer.js',
'test/unit/test-json.js',
'test/unit/test-layout-rect.js',
'test/unit/test-layout.js',
'test/unit/test-log.js',
'test/unit/test-mode.js',
'test/unit/test-motion.js',
'test/unit/test-mustache.js',
'test/unit/test-mutator.js',
'test/unit/test-object.js',
'test/unit/test-observable.js',
'test/unit/test-pass.js',
'test/unit/test-platform.js',
'test/unit/test-polyfill-document-contains.js',
'test/unit/test-polyfill-math-sign.js',
'test/unit/test-polyfill-object-assign.js',
'test/unit/test-polyfill-object-values.js',
'test/unit/test-preconnect.js',
'test/unit/test-pull-to-refresh.js',
'test/unit/test-purifier.js',
'test/unit/test-render-delaying-services.js',
'test/unit/test-resource.js',
'test/unit/test-resources.js',
'test/unit/test-sanitizer.js',
'test/unit/test-service.js',
'test/unit/test-size-list.js',
'test/unit/test-srcset.js',
'test/unit/test-static-template.js',
'test/unit/test-string.js',
'test/unit/test-style-installer.js',
'test/unit/test-style.js',
'test/unit/test-task-queue.js',
'test/unit/test-transition.js',
'test/unit/test-types.js',
'test/unit/test-url-rewrite.js',
'test/unit/test-url.js',
'test/unit/test-viewport.js',
'test/unit/test-web-components.js',
'test/unit/utils/test-array.js',
'test/unit/utils/test-base64.js',
'test/unit/utils/test-bytes.js',
'test/unit/utils/test-lru-cache.js',
'test/unit/utils/test-pem.js',
'test/unit/utils/test-priority-queue.js',
'test/unit/utils/test-rate-limit.js',
'test/unit/web-worker/test-amp-worker.js',

@rsimha
Copy link
Contributor Author

rsimha commented Apr 22, 2021

[Infra triage] Putting this on the radar of @rileyajones for comment / prioritization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants