Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Replace legacy describe with describes.sandboxed #32848

Merged
merged 3 commits into from Feb 24, 2021
Merged

✅ Replace legacy describe with describes.sandboxed #32848

merged 3 commits into from Feb 24, 2021

Conversation

dmanek
Copy link
Contributor

@dmanek dmanek commented Feb 24, 2021

Partial for #24144.

@dmanek dmanek marked this pull request as ready for review February 24, 2021 00:42
rsimha
rsimha approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

micajuine-ho
micajuine-ho approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@micajuine-ho micajuine-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the decision for targeting these 5 file tests?

@dmanek
Copy link
Contributor Author

dmanek commented Feb 24, 2021

What was the decision for targeting these 5 file tests?

Just went thru the list in presubmit-checks.js and fixed the ones I thought were low hanging fruit 🙂

@dmanek dmanek merged commit e908431 into ampproject:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

@micajuine-ho micajuine-ho micajuine-ho approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmanek @rsimha @micajuine-ho @ampprojectbot