Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow analytics vendor to print out deprecation info #24554

Closed
zhouyx opened this issue Sep 16, 2019 · 0 comments · Fixed by #24777
Closed

Allow analytics vendor to print out deprecation info #24554

zhouyx opened this issue Sep 16, 2019 · 0 comments · Fixed by #24777

Comments

@zhouyx
Copy link
Contributor

zhouyx commented Sep 16, 2019

Related to #24261 (comment)

We get a few requests from analytics vendor to upgrade their solution and deprecate old ones.
To help vendors with the migration process, we could print out the deprecation info to developers whenever there's such usage.

Proposal: add an deprecated field to the analytics jSON config.

For example, deprecated_vendor will have config like

{
  'deprecated': 'deprecated, please migrate to new_vendor'
}

Then whenever <amp-analytics type='deprecated_vendor'> is used, AMP will print out the specified console error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants