Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 📖 Vendor config warning message #24777

Merged
merged 3 commits into from Oct 2, 2019

Conversation

micajuine-ho
Copy link
Contributor

@micajuine-ho micajuine-ho commented Sep 27, 2019

Added the ability for vendors to include the top-level property warningMessage in their configs to warn developers of things such as deprecation/migration. Closes #24554
/cc @zhouyx

extensions/amp-analytics/0.1/config.js Show resolved Hide resolved
extensions/amp-analytics/0.1/test/test-config.js Outdated Show resolved Hide resolved
extensions/amp-analytics/0.1/test/test-config.js Outdated Show resolved Hide resolved
extensions/amp-analytics/0.1/test/test-config.js Outdated Show resolved Hide resolved
extensions/amp-analytics/amp-analytics.md Outdated Show resolved Hide resolved
extensions/amp-analytics/amp-analytics.md Outdated Show resolved Hide resolved
extensions/amp-analytics/amp-analytics.md Outdated Show resolved Hide resolved
Copy link
Contributor

@zhouyx zhouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 🎉 🎉

@zhouyx
Copy link
Contributor

zhouyx commented Oct 2, 2019

@rcebulko could you help take a look at the owner file? I don't think it's recognizing wg-analytics. Thanks

@rcebulko
Copy link
Contributor

rcebulko commented Oct 2, 2019

@rcebulko could you help take a look at the owner file? I don't think it's recognizing wg-analytics. Thanks

just like how if you tried to tag @wg-analytics in GitHub it would fail (since that's not a user name), it fails here because to the owners bot it looks like you were specifying a username, not a team name. For teams, just like with @mentions/tagging, you'd write ampproject/wg-analytics.

Please review #24865 , and merge if possible since I don't have merge access. Once that is merged, this PR will have owners coverage

@zhouyx
Copy link
Contributor

zhouyx commented Oct 2, 2019

Thank you @micajuine-ho and @rcebulko

@zhouyx zhouyx merged commit e231b7a into ampproject:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow analytics vendor to print out deprecation info
4 participants