Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in story progress-bar method name. #24715

Closed
gmajoulet opened this issue Sep 24, 2019 · 0 comments · Fixed by #24816
Closed

Typo in story progress-bar method name. #24715

gmajoulet opened this issue Sep 24, 2019 · 0 comments · Fixed by #24816
Assignees
@jackbsteinberg
Labels
P3: When Possible Type: Bug WG: stories

Comments

@gmajoulet
Copy link
Contributor

Good first issue:

The method assertVaildSegmentId_ has a typo, in https://github.com/ampproject/amphtml/blob/master/extensions/amp-story/1.0/progress-bar.js#L473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackbsteinberg jackbsteinberg

Labels
P3: When Possible Type: Bug WG: stories
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fix typo in assertValidSegmentId_ method name jackbsteinberg/amphtml
2 participants
@gmajoulet @jackbsteinberg