Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Fix typo in assertValidSegmentId_ method name #24816

Merged
merged 1 commit into from Sep 30, 2019
Merged

馃悰 Fix typo in assertValidSegmentId_ method name #24816

merged 1 commit into from Sep 30, 2019

Conversation

jackbsteinberg
Copy link
Contributor

Corrects spelling in the definition and usages of the assertValidSegmentId_ method name (was previously assertVaildSegmentId_).

Resolves #24715

@amp-owners-bot
Copy link

Hey @gmajoulet, these files were changed:

  • extensions/amp-story/1.0/progress-bar.js

newmuis
newmuis approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@newmuis newmuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀

@amp-owners-bot
Copy link

Hey @gmajoulet, these files were changed:

  • extensions/amp-story/1.0/progress-bar.js

@gmajoulet gmajoulet merged commit 04fdc51 into ampproject:master Sep 30, 2019
@jackbsteinberg jackbsteinberg deleted the starter-typo-fix branch September 30, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

@newmuis newmuis newmuis approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in story progress-bar method name.
4 participants
@jackbsteinberg @gmajoulet @newmuis @googlebot