Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-carousel 0.2 auto snap to start position when page scroll occured #24750

Closed
meistudioli opened this issue Sep 26, 2019 · 4 comments
Closed
Labels

Comments

@meistudioli
Copy link
Contributor

meistudioli commented Sep 26, 2019

To whom it may concern:

I've already migrate amp-carousel to Version 0.2 and feel something strange about the action.

※ Reproduce step:

  1. horizontal scroll one amp-carousel.
  2. page scroll occured.
  3. amp-carousel auto snap to the start position.

video: https://youtu.be/T39di7eVJQE

※ Expect:
Keep it alone. I don't want to bother user to scroll back again.

demo address: https://tw.bid.yahoo.com/amp/homepage

Above example is test from iOS 13.1 Safari.

I wonder is this an issue or not.

Paul

@sparhami
Copy link

Looking at the linked page, it seems like it no longer uses amp-carousel for the section outlined in the video.

I tried creating a jsbin (http://output.jsbin.com/mazajac) to reproduce the issue, but I don't seem to be able to reproduce on iOS 13.1.

Do you still have a page available where this issue occurs?

@conwaydev
Copy link

@sparhami I’m still seeing the behavior at https://amp.dev/documentation/examples/components/amp-carousel/

@sparhami
Copy link

sparhami commented Oct 1, 2019

@sparhami I’m still seeing the behavior at https://amp.dev/documentation/examples/components/amp-carousel/

That page is using amp-carousel 0.1, (we should update it to 0.2), but the issue above is about 0.2 specifically. The issue for 0.1 will be fixed when #24771 goes live.

@stale
Copy link

stale bot commented Mar 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Mar 25, 2021
@stale stale bot closed this as completed Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants