馃悰Fix non-carousel scrolling on iOS 13 reverting to first slide. #24771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One effect of these changes is that on slow swipes, the carousel takes longer to switch over to the snapped slide, since the scroll momentum needs to stop before the snap instead of snapping shortly after the touch is released. - Change how the snapping/scroll end is handled with respect to touch events and scroll. - As long as the user is touching, do not snap the position. - Do not snap after swipe is released like before, wait for scrolling to stop. - Increase the timeout after the last scroll event to be more robust.
|
Pushed a version to test here: https://amp-testing-715cb.firebaseapp.com/manual/amp-carousel/0.1/slides.amp.html. Did some testing on iOS12, iOS13 and Android to make sure this change does cause any major problems. |
wassgha
approved these changes
Sep 27, 2019
This was referenced Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One effect of these changes is that on slow swipes, the carousel
takes longer to switch over to the snapped slide, since the scroll
momentum needs to stop before the snap instead of snapping shortly after
the touch is released.
events and scroll.
to stop.
Fixes #24541