Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-date-picker: allow to hide keyboard shortcuts panel #25608

Closed
ruipvs opened this issue Nov 15, 2019 · 3 comments · Fixed by #25741
Closed

amp-date-picker: allow to hide keyboard shortcuts panel #25608

ruipvs opened this issue Nov 15, 2019 · 3 comments · Fixed by #25741
Labels
Component: amp-date-picker Customer: Developer GFI Candidate P3: When Possible Type: DevX issues impacting developer experience Type: Feature Request WG: components

Comments

@ruipvs
Copy link
Contributor

ruipvs commented Nov 15, 2019

Describe the new feature or change to an existing feature you'd like to see

As in react-date, by AirBnB, we can set a flag to hide the keyboard shortcuts panel, in amp we should be able to set a flag to do this too

In react-date the flag is hideKeyboardShortcutsPanel
@nainar
Copy link
Contributor

nainar commented Nov 15, 2019

Hi @rpsilva would you be interested in making that change?

@ruipvs
Copy link
Contributor Author

ruipvs commented Nov 20, 2019

Hi @nainar yes I'm interested in making this change, could you help how to configure the project in my local machine? Or is there a guide to get started?

@ruipvs
Copy link
Contributor Author

ruipvs commented Nov 21, 2019

Hi @nainar yes I'm interested in making this change, could you help how to configure the project in my local machine? Or is there a guide to get started?

@nainar I have finally configured the project and I have done the issue. I have committed to my branch. What's the next step?

ruipvs added a commit to ruipvs/amphtml that referenced this issue Nov 22, 2019
@ruipvs
amp-date-picker: allow to hide keyboard shortcuts panel ampproject#25608
1e98fd1
ruipvs added a commit to ruipvs/amphtml that referenced this issue Nov 23, 2019
@ruipvs
amp-date-picker: allow to hide keyboard shortcuts panel ampproject#25608
b732b1e 
 ampproject#25741

added 'hide-keyboard-shortcuts-panel' into attributesToForward
ruipvs added a commit to ruipvs/amphtml that referenced this issue Nov 23, 2019
@ruipvs
amp-date-picker: allow to hide keyboard shortcuts panel ampproject#25608
8a1c578 


Added unit test and validation rules
@ruipvs ruipvs mentioned this issue Dec 2, 2019
Merged
ruipvs added a commit to ruipvs/amphtml that referenced this issue Dec 3, 2019
@ruipvs
amp-date-picker: allow to hide keyboard shortcuts panel ampproject#25608
63544a9 
 ampproject#25741

Executed travis command to fix
ruipvs added a commit to ruipvs/amphtml that referenced this issue Dec 4, 2019
@ruipvs
amp-date-picker: allow to hide keyboard shortcuts panel ampproject#25608
c4d7e8c 


ampproject#25741
Executed travis command prettify to fix
caroqliu pushed a commit that referenced this issue Jan 7, 2020
@ruipvs @caroqliu
✨ amp-date-picker: allow to hide keyboard shortcuts panel #25608 (#25741
55ac520 
)

* amp-date-picker: allow to hide keyboard shortcuts panel #25608

* amp-date-picker: allow to hide keyboard shortcuts panel #25608 #25741
added 'hide-keyboard-shortcuts-panel' into attributesToForward

* Updated amp-date-picker.md

* amp-date-picker: allow to hide keyboard shortcuts panel #25608
Added unit test and validation rules

* amp-date-picker: allow to hide keyboard shortcuts panel #25608 #25741
Executed travis command to fix

* amp-date-picker: allow to hide keyboard shortcuts panel #25608
#25741
Executed travis command prettify to fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: amp-date-picker Customer: Developer GFI Candidate P3: When Possible Type: DevX issues impacting developer experience Type: Feature Request WG: components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ amp-date-picker: allow to hide keyboard shortcuts panel #25608 ruipvs/amphtml
2 participants
@nainar @ruipvs