Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story bot render mode: Force text to be visible #26528

Closed
cramforce opened this issue Jan 28, 2020 · 3 comments · Fixed by #26571
Closed

Story bot render mode: Force text to be visible #26528

cramforce opened this issue Jan 28, 2020 · 3 comments · Fixed by #26571
Assignees

Comments

@cramforce
Copy link
Member

The text inferred from slide titles and video alt attributes should be forced to be readable.

This could e.g. be achieved by setting the background color of the text and the color of the text to different, high contrast colors. Today it can happen that a story e.g. sets a white background color and a white text color which works, because the text is usually not shown directly over the page background.

@gmajoulet
Copy link
Contributor

Did you notice that on a specific story?

We already have some CSS that should prevent this from happening, I'd be curious to see what kind of publisher provided CSS overrode it:

[i-amphtml-vertical] .i-amphtml-story-page-description {
background: white !important;
color: black !important;

@cramforce
Copy link
Member Author

Interesting. I thought I saw it, but I must have been mistaken. Will keep an eye out for it!

@cramforce
Copy link
Member Author

One tiny change: Should we made width: auto instead of width:100%. Right now, because of the padding, the text runs over the right screen.

@cramforce cramforce reopened this Jan 29, 2020
cramforce added a commit to cramforce/amphtml that referenced this issue Jan 31, 2020
Otherwise the padding leads to the text going over the edge of the right side of the screen.

Fixes ampproject#26528
gmajoulet pushed a commit that referenced this issue Jan 31, 2020
Otherwise the padding leads to the text going over the edge of the right side of the screen.

Fixes #26528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants