Design Review 2020-04-22 15:30 UTC (error issue creation, CSS in Bento, wg-stories)

[mrjoro]

Time: 2020-04-22 15:30 UTC (add to Google Calendar)
Location: Video conference via Google Meet

The AMP community holds weekly engineering design reviews. We encourage everyone in the community to participate in these design reviews.

If you are interested in bringing your design to design review, read the design review documentation and add a link to your design doc or issue by the Monday before your design review.

When attending a design review please read through the designs before the design review starts. This allows us to spend more time on discussion of the design.

We rotate our design review between times that work better for different parts of the world as described in our design review documentation, but you are welcome to attend any design review. If you cannot make any of the design reviews but have a design to discuss please let mrjoro@ know on Slack and we will find a time that works for you.

[mrjoro]

The Stories Working Group will be presenting their periodic updates at this Design Review (10-15 minutes).

/cc @ampproject/wg-stories @newmuis

[rcebulko]

I'd like to share the plans for a work-in-progress bot to file issues for production errors automatically (#27675)

Edit: Should take ~15 mins depending on discussion/questions

/cc @ampproject/wg-infra

[jorydotcom]

@mrjoro - @sumodas plans to join from the @ampproject/ac

[caroqliu]

I'd like to discuss CSS in Bento AMP if time allows.

[newmuis]

I can only attend the second half of this meeting; would be great to push the stories WG update towards the end, if possible.

If not, the notes can be seen at ampproject/wg-stories#35, and will also be loosely discussed in the wg-stories April Working Group Meeting.

[caroqliu]

Notes about CSS in Bento AMP:

• High level summary of styling in AMP today:
  • surface area for styling increase by adding Bento and Preact modes
  • two types of default styles AMP uses today (functionally critical versus decorative)
• Open questions:
  • inline styling shortcomings i.e. pseudoselectors, additional cost of shipping in JS not always worth it
  • styles lost when component children elements cross light/shadow DOM threshold
  • how to distribute optional decorative styles
• Suggestions from discussion:
  • Be careful to have an option to get styles embedded in JS and not
  • Focus on how publishers can consume styles and output them themselves

[rcebulko]

Primary takeaway for error issue creation: Security/privacy concerns about errors that could contain PII or other sensitive info being auto-published

• Risk is somewhat reduced by thresholding
• Some sort of moderation/approval buffer would be good
• Possible workaround: Create issue in separate private ampproject repo with link to duplicate into amphtml
• Alternate workaround: Release dashboard integration + separate alerting