Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch errors in publisher amp-script code #28198

Closed
rcebulko opened this issue May 5, 2020 · 1 comment · Fixed by #28207
Closed

Catch errors in publisher amp-script code #28198

rcebulko opened this issue May 5, 2020 · 1 comment · Fixed by #28207

Comments

@rcebulko
Copy link
Contributor

rcebulko commented May 5, 2020

It seems that in cases (example: #27904) where custom amp-script code from publishers causes errors, those errors bubble up into an unhandled promise rejection, and are reported to AMP Error Reporting. This adds noise to error reporting, as the underlying issue is one with publisher code, not with AMP code. These errors should be caught and reported as user errors.

/cc @jridgewell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants