amp-script: catch user errors in worker scripts #28207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcebulko
approved these changes
May 5, 2020
jridgewell
approved these changes
May 5, 2020
| @@ -247,6 +247,13 @@ export class AmpScript extends AMP.BaseElement { | |||
| config | |||
| ).then((workerDom) => { | |||
| this.workerDom_ = workerDom; | |||
| this.workerDom_.onerror = (errorEvent) => { | |||
There was a problem hiding this comment.
Is workerDom a Worker instance?
There was a problem hiding this comment.
yep. its...a worker from worker-dom. It would potentially make sense to just name it worker. This is the exact API I plan on changing in ampproject/worker-dom#850
dreamofabear
approved these changes
May 5, 2020
ldoroshe
pushed a commit
to ldoroshe/amphtml
that referenced
this pull request
May 8, 2020
* amp-script: catch user errors in worker scripts * remove obnoxious laughs
ampprojectbot
added
PR use: In Beta / Experimental
PR use: In Stable
and removed
PR use: In Stable
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Fixes #28198.
Adds an
onerrorhandler to the worker script so that we can rethrow all errors as user errors instead of bubbling into a dev one. This should help clear some noise from the error tracker.Here's a screenshot of the new error format:
cc @rcebulko @ampproject/wg-runtime