Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixit: make gulp e2e directly call dist() and build() #28312

Closed
samouri opened this issue May 11, 2020 · 0 comments · Fixed by #28326
Closed

Fixit: make gulp e2e directly call dist() and build() #28312

samouri opened this issue May 11, 2020 · 0 comments · Fixed by #28326
Assignees

Comments

@samouri
Copy link
Member

samouri commented May 11, 2020

summary
Currently the gulp e2e spawns a new process to call either gulp dist or gulp build. We can potentially simplify the code and get all the flag parsing for free by instead directly calling dist() or build(). This idea was originally suggested by @rsimha.

@samouri samouri changed the title Fixit: fixit: make gulp e2e directly call dist() and build() May 11, 2020
@samouri samouri changed the title fixit: make gulp e2e directly call dist() and build() Fixit: make gulp e2e directly call dist() and build() May 11, 2020
@rsimha rsimha self-assigned this May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants