🏗Allow gulp tasks to programmatically build the runtime
#28326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
changed the title
gulp tasks to programmatically build the runtime in-processgulp tasks to programmatically build the runtime
|
Hey @erwinmombay! These files were changed: Hey @estherkim! These files were changed: |
samouri
approved these changes
May 12, 2020
|
All Travis tests are green. Tested the following 12 permutations locally, looks good to merge 🤞 gulp {e2e|integration|visual-diff} [--nobuild] [--compiled] |
rcebulko
reviewed
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
Testing tasks like
e2e,integration, andvisual-diffrequire fully built AMP binaries. On Travis, we like to run them on minified code, while for local development, we'd like the option of using unminified or minified code.PR highlights:
doBuild()/doDist()tobuild.js/dist.jsto allow for in-process compilationoptionsparam through which args can be plumbedargv.fortestingusage to top-level entry points (other places useoptions)buildRuntime()and reuses it ine2e,integration, andvisual-diff--compiledflag fore2e,integration, andvisual-diffTESTING.mdOn Travis, this PR is a no-op, and tests will continue to run against minified code. For local testing, the default behavior (without
--compiled) is to run on unminified code, which can be considerably faster.Fixes #28312
Follow up to #28305