Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Story Ad: move CTA to shadow DOM #28865

Closed
calebcordry opened this issue Jun 12, 2020 · 1 comment 路 Fixed by #32850
Closed

馃悰 Story Ad: move CTA to shadow DOM #28865

calebcordry opened this issue Jun 12, 2020 · 1 comment 路 Fixed by #32850

Comments

@calebcordry
Copy link
Member

Pub styles are leaking to the button affecting letter spacing, eg https://www.10best.com/web-stories/how-to-extend-the-life-of-your-spices-and-herbs/

image

@gmajoulet
Copy link
Contributor

Even in a Shadow DOM, inherited properties will pierce the Shadow DOM boundaries. If that helps, we're using this reset on top of Shadow DOM to fully scope Story components: https://github.com/ampproject/amphtml/blob/master/extensions/amp-story/1.0/amp-story-shadow-reset.css

@calebcordry calebcordry added this to To do in wg-monetization fixit week 2/2021 via automation Feb 18, 2021
@calebcordry calebcordry moved this from To do to In progress in wg-monetization fixit week 2/2021 Feb 22, 2021
wg-monetization fixit week 2/2021 automation moved this from In progress to Done Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants