Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Move Story Ads CTA to shadow #32850

Merged
merged 3 commits into from Feb 24, 2021
Merged

✨Move Story Ads CTA to shadow #32850

merged 3 commits into from Feb 24, 2021

Conversation

calebcordry
Copy link
Member

Isolates pub styles from runtime styles to protect the CTA button.

Closes #28865

danielrozenberg
danielrozenberg approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@danielrozenberg danielrozenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for build-system/

@calebcordry calebcordry merged commit 775b5f6 into ampproject:master Feb 24, 2021
@calebcordry calebcordry deleted the cta-shadow branch February 24, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerivq powerivq powerivq approved these changes

@danielrozenberg danielrozenberg danielrozenberg approved these changes

@lannka lannka lannka approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Story Ad: move CTA to shadow DOM
5 participants
@calebcordry @powerivq @danielrozenberg @lannka @ampprojectbot