Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Story 360] Add tilt attributes #29514

Closed
gmajoulet opened this issue Jul 24, 2020 · 1 comment
Closed

[Story 360] Add tilt attributes #29514

gmajoulet opened this issue Jul 24, 2020 · 1 comment
Assignees
@gmajoulet
Labels
P2: Soon Type: Feature Request WG: stories
Projects
wg-stories Story-360

Comments

@gmajoulet
Copy link
Contributor

Add tilt-pitch and tilt-yaw for better publisher control over their 360 assets.

cc @ampproject/wg-stories
@gmajoulet gmajoulet self-assigned this Jul 24, 2020
@t0mg t0mg mentioned this issue Sep 7, 2020
Merged
wg-stories Story-360 automation moved this from To do to Done Sep 17, 2020
@gmajoulet gmajoulet added this to To do in wg-stories Sprint via automation Sep 17, 2020
@gmajoulet gmajoulet moved this from To do to Done in wg-stories Sprint Sep 17, 2020
@gmajoulet
Copy link
Contributor Author

From @t0mg

The updated API is scene-heading, scene-pitch and scene-roll. We ditched the yaw/tilt-yaw/tilt-pitch and quaternion implementation in favor of new attributes that rely on Euler angles instead. It better matches Zuho implementation and most importantly it feels less quirky / specific to Street View panoramas. The scene-* coordinates are absolute and applied as a rotation matrix to the rendered panorama.

@gmajoulet gmajoulet removed this from Done in wg-stories Sprint Oct 9, 2020
ed-bird pushed a commit to ed-bird/amphtml that referenced this issue Dec 10, 2020
@t0mg @ed-bird
✨ [amp-story-360] Add scene orientation support (fixes ampproject#29514…
92c29d1 
…) (ampproject#30138)

* Base element with a working example

* Add amp-img to test file

* Fix base test, add play/pause/rewind methods

* revert example to proper state

* revert example to master state (for now)

* actually revert example to master state (with new line)

* Add comment in zuho's README.amp

* Implement play/pause support for amp-story-360 in amp-story-page

* Fix test

* Update/add validator tests

* restore missing newlines (wat)

* more newline nonsense

* Add tilt attributes to validator

* Update example

* Add orientation correction support to zuho library

* Replacing tilt API with Euler angles for scene orientation correction

* Remove unused Quaternion class

* Whitespace & validator text fixes

* Lint fix

* Lint fix 2

* Lint fix 3 the fixening
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmajoulet gmajoulet

Labels
P2: Soon Type: Feature Request WG: stories
Projects
wg-stories Story-360
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gmajoulet