✅ 360 component visual diff test #30739
Conversation
|
Do you know why it's not loading on Percy? |
|
|
I think it's not waiting until the image loads. I'll look into the |
| }, | ||
| () => { | ||
| user().error(TAG, 'Failed to load the amp-video.'); | ||
| } | ||
| ); | ||
| } | ||
|
|
||
| /** @private */ | ||
| addClassForVisualTests_() { |
There was a problem hiding this comment.
We usually never ship code that is only meant to help testing, but we can always rename this method and make it reusable in the future for other use cases.
Maybe we can add a *-loaded class in a markAsLoaded_() method to replicate amp-story.js behavior?
processprocess
force-pushed
the
visual-tests
branch
from
35cd698
to
33dbb11
Compare
There was a problem hiding this comment.
Can we edit the assets to not bloat the AMPHTML repository? I'm worried about every single AMPHTML engineer having to download these when they clone the repository.
The png can be heavily optimized, even if it ends up becoming pretty low quality. As long as it renders we're good.
For the video, can we edit it to just keep the first half second or something?
processprocess
force-pushed
the
visual-tests
branch
from
4a1a4c9
to
05e6907
Compare
|
CC @danielrozenberg As we've discussed, WebGL might not be rendering in Percy. update: This might be because Percy takes a DOM snapshot and does not capture the state of the canvas element. |
|
Hey @danielrozenberg! These files were changed: Hey @gmajoulet, @t0mg! These files were changed: |
|
cc @danielrozenberg & @erwinmombay for owners approval. |
* rebase * Update html template * Fix typo in comment. * rebase * rebase * rebase * rebase * Add video assets to visual-tests folder. * Compress assets. * rebase * Edit loading selector. * Require amp-video * merge conflict * merge conflicts * revert line * loading selector * Fix image path and selector. * Remove controls gyroscope. * Replace canvas with image for percy dom state. * remove image type and quality. * Add flag for testing in zuho and visual tests. * heading on video. * Remove video test. * use replacewith
Visual diff test for rendering a 360 image.
cc @ampproject/wg-stories