-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amp-sidebar not opening in the viewer in FF #30819
Comments
Is it a Story specific or AMP bug? Did you try the feature in a regular AMP document? |
the Side bar feature works properly in the amp page |
I think that screenshot is from Chrome, and doesn't look like it's opened from the viewer, though? Could we confirm this in an AMP document opened in FF in a viewer please @Ichigo3d ? |
I think we'd need to try it on an AMP page opened in the google viewer, I don't thing the amp.dev sample is opened in one. |
We identified that this was due to an error with the testing environment (Firefox tests were using a iOS 12 user-agent, should be using modern UA that does not use FixedLayer). |
Trying to open the
amp-sidebar
in an AMP doc opened in the viewer from the Google Search results page results in a failure. The opacity of the story is decreased (expected) but no sidebar is opened (unexpected).A suspicious warning also appears when clicking the sidebar:
Steps to repro:
The text was updated successfully, but these errors were encountered: