Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-sidebar not opening in the viewer in FF #30819

Closed
Enriqe opened this issue Oct 22, 2020 · 7 comments
Closed

amp-sidebar not opening in the viewer in FF #30819

Enriqe opened this issue Oct 22, 2020 · 7 comments

Comments

@Enriqe
Copy link
Contributor

Enriqe commented Oct 22, 2020

Trying to open the amp-sidebar in an AMP doc opened in the viewer from the Google Search results page results in a failure. The opacity of the story is decreased (expected) but no sidebar is opened (unexpected).

A suspicious warning also appears when clicking the sidebar:

[FixedLayer] In order to improve scrolling performance in Safari, we now move the element to a fixed positioning layer: 
<amp-sidebar id="story-sb" class="style-1 i-amphtml-layout…idebar i-amphtml-layout" i-amphtml-layout="nodisplay" layout="nodisplay" side="right" role="menu" tabindex="-1" i-amphtml-fixedid="F0" style="pointer-events: initial; top: calc(0px);" open="">

Steps to repro:

  1. In firefox mobile emulation, search "fun things to do in nyc"
  2. scroll down until you find the corresponding story. (https://www.google.com/amp/story/s/travel.visualstories.com/fun-things-to-do-in-nyc)
  3. try opening the sidebar

image

@Enriqe Enriqe changed the title amp-sidebar not opening in viewer in FF amp-sidebar not opening in stories opened in the viewer in FF Oct 22, 2020
@gmajoulet
Copy link
Contributor

Is it a Story specific or AMP bug? Did you try the feature in a regular AMP document?

@Ichigo3d
Copy link

the Side bar feature works properly in the amp page

@Ichigo3d
Copy link

Screen Shot 2020-10-22 at 8 31 42 AM

@Enriqe
Copy link
Contributor Author

Enriqe commented Oct 22, 2020

I think that screenshot is from Chrome, and doesn't look like it's opened from the viewer, though? Could we confirm this in an AMP document opened in FF in a viewer please @Ichigo3d ?

@Enriqe
Copy link
Contributor Author

Enriqe commented Oct 22, 2020

I think we'd need to try it on an AMP page opened in the google viewer, I don't thing the amp.dev sample is opened in one.

@Enriqe
Copy link
Contributor Author

Enriqe commented Oct 22, 2020

Searching for [balance-positivo-para-el-segundo-fin-de-semana-con-salidas-recreativas-en-carlos-paz] and opening the AMP doc in FF yields the same results. This is an amp-sidebar bug. @ampproject/wg-components

image

@Enriqe Enriqe changed the title amp-sidebar not opening in stories opened in the viewer in FF amp-sidebar not opening in the viewer in FF Oct 22, 2020
@kevinkimball
Copy link
Contributor

We identified that this was due to an error with the testing environment (Firefox tests were using a iOS 12 user-agent, should be using modern UA that does not use FixedLayer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants