wg-performance Status Update 2020-10-26

[erwinmombay]

What was accomplished

• integration fixture files are now transformed through postHTML
• safari fix for block scoping performance regression (can be 3x to 10x slower)
• Investigated Firefox amp-sidebar FixedLayer bug, turned out to be testing setup misconfiguration (amp-sidebar not opening in the viewer in FF amphtml#30819)
• Removing {BaseElement.viewportCallback}: 3 PRs currently in flight, as well as a few merged (AMP Video Players: use IntersectionObserver instead of viewportCallback + scroll detection. amphtml#30647, Remove viewportCallback from the rest of non-ads related components. amphtml#30802, Remove BaseElement.viewportCallback from ads. amphtml#30859). One already merged (utility: add viewport-observer amphtml#30761)
• Various test fixes, including aligning unit tests with prod-config: unit tests: align with prod-config amphtml#30535

Lessons Learned

• function definitions can be recursively redefined. (function f() { f = () => 5; return 7})

What's Next

• esm to 100% (monitoring safari performance)
• esm e2e tests
• continue removing viewportCallback as well as associated code
• research two Dynamic Mail bugs probably related to intersect-resources.

[samouri]

what was accomplished

• Removing {BaseElement.viewportCallback}: 3 PRs currently in flight, as well as one merged (AMP Video Players: use IntersectionObserver instead of viewportCallback + scroll detection. amphtml#30647, Remove viewportCallback from the rest of non-ads related components. amphtml#30802, Remove BaseElement.viewportCallback from ads. amphtml#30859). One already merged (utility: add viewport-observer amphtml#30761)
• Various test fixes, including aligning unit tests with prod-config: unit tests: align with prod-config amphtml#30535

lessons learned

• function definitions can be recursively redefined. (function f() { f = () => 5; return 7})

whats next

• continue removing viewportCallback as well as associated code
• research two Dynamic Mail bugs probably related to intersect-resources.

[jridgewell]

What was accomplished

AMP Core

• Fix polyfills in ESM mode: #30624, #30630
• Fixes for amp-sticky-ad collapsing: 🔥 Only collapse sticky-ad when ad collapses amphtml#30730
• Fix broken query selector affecting IE11: Fix broken query selector amphtml#30850
• babel-plugin-transform-block-scoping: add babel-plugin-transform-block-scoping amphtml#30807

Packager

• Allow arbitrary <link rel=preload> header extraction: Add arbitrary preload attributes to Link header amppackager#475
• Extract <link rel=preload as=image> into headers: cl/337974534
• Inject <img loading=lazy> for all <amp-img>: cl/336760832
• Support imagesrcset and imagesizes when ingesting SXG: cl/337985664

SSR

• Inject amp-usqp meta for SSR transformer CSI: cl/337537376

Lessons Learned

What's next

• Finishing Bento auto-envelope design doc and PR
• Write design doc on AVIF image format in cache
• On duty this week