Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "master" branch to "main" #32195

Closed
baconjulie opened this issue Jan 25, 2021 · 8 comments
Closed

Rename "master" branch to "main" #32195

baconjulie opened this issue Jan 25, 2021 · 8 comments

Comments

@baconjulie
Copy link

Following up on our discussion in the 1/25 AMP AC Meeting to rename the master branch to main or a similar name.

@tobie
Copy link
Contributor

tobie commented Jan 25, 2021

Fixed for meta-ac repository.

Edit: Clarified post transfer from meta-ac.

@kristoferbaxter kristoferbaxter transferred this issue from ampproject/meta-ac Jan 25, 2021
@rsimha rsimha self-assigned this Jan 25, 2021
@rsimha
Copy link
Contributor

rsimha commented Jan 25, 2021

Thanks for filing this issue @baconjulie, and for transferring it to amphtml, @kristoferbaxter.

I see the renaming guide at https://github.com/github/renaming. This is useful.

Right now, there are a few hundred references to master in amphtml's build-system code and our custom app repo amp-github-apps combined. In addition, there are O(1000) references in various amphtml files. Moreover, our internal release system that works on amphtml has a few references too.

While it is possible to change these (and I fully support the sentiment behind making this change), doing so will involve several intricately coordinated steps. Happy to put this on our team's backlog.

@kristoferbaxter Can you comment on the priority this move should get? Would we like to see this happen within days? weeks? a couple months? the end of the year?

@kristoferbaxter
Copy link
Contributor

For clarity, the default branch name for ampproject at the org level is main. This was changed after both amphtml and meta-ac were created though.

Screen Shot 2021-01-25 at 3 56 12 PM

@rsimha If this was complete within a quarter I'd consider it a success given the different moving pieces. We've held off on doing it too long.

@rsimha
Copy link
Contributor

rsimha commented Mar 31, 2021

This work has begun, and we are in the process of planning / coordinating updates to the various moving parts. (See this doc.) I'll post a final update here when the transition is complete.

@tobie
Copy link
Contributor

tobie commented Mar 31, 2021

Love the design doc!

Do you mind if I share it with the other OpenJSF projects?

@rsimha
Copy link
Contributor

rsimha commented Mar 31, 2021

Do you mind if I share it with the other OpenJSF projects?

Not at all. Feel free to share. (The plan is still being reviewed, any necessary updates will be made in the next few days.)

This was referenced Apr 8, 2021
@rsimha
Copy link
Contributor

rsimha commented Apr 26, 2021

Closing out this top-level issue now that the default branches of amphtml and almost every other repo under amppproject have been renamed. There are two or three repos left, and their issues are linked above.

@rsimha rsimha closed this as completed Apr 26, 2021
@tobie
Copy link
Contributor

tobie commented Apr 26, 2021

Amazing. Congrats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants