Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update links that were pointing to the master branch of amp-github-apps #33571

Merged
merged 1 commit into from
Apr 7, 2021
Merged

📖 Update links that were pointing to the master branch of amp-github-apps #33571

merged 1 commit into from
Apr 7, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Mar 31, 2021

This PR updates all links in amphtml documentation that were pointing to the master branch of the amp-github-apps repo to use main instead. It can be merged at leisure after the branch is renamed (see this plan), because GitHub links are auto-redirected.

Sending this out for review and owners approval. On self-review, this PR changes only the documentation comments in our OWNERS files, so it should be fairly safe to merge after the branch rename. (Won't merge until after the rename is complete.)

Partial fix for #32195

@amp-owners-bot
Copy link

amp-owners-bot bot commented Mar 31, 2021

Hey @erwinmombay! These files were changed:

build-system/babel-plugins/OWNERS
build-system/eslint-rules/OWNERS

Hey @jridgewell! These files were changed:

build-system/babel-plugins/OWNERS
build-system/eslint-rules/OWNERS
src/core/OWNERS

Hey @alanorozco! These files were changed:

build-system/server/app-index/OWNERS
build-system/tasks/markdown-toc/OWNERS
build-system/tasks/storybook/OWNERS

Hey @estherkim! These files were changed:

build-system/tasks/e2e/OWNERS

Hey @danielrozenberg! These files were changed:

build-system/tasks/visual-diff/OWNERS

Hey @Jiaming-X! These files were changed:

extensions/amp-ad-network-adsense-impl/OWNERS

Hey @jeffkaufman! These files were changed:

extensions/amp-ad-network-adsense-impl/OWNERS
extensions/amp-ad-network-doubleclick-impl/OWNERS

Hey @gmajoulet! These files were changed:

extensions/amp-cache-url/OWNERS
extensions/amp-story-360/OWNERS
extensions/amp-story-dev-tools/OWNERS
extensions/amp-story-education/OWNERS
extensions/amp-story-interactive/OWNERS
extensions/amp-story-panning-media/OWNERS
extensions/amp-story-player/OWNERS
extensions/amp-story/OWNERS

Hey @mszylkowski! These files were changed:

extensions/amp-cache-url/OWNERS
extensions/amp-story-dev-tools/OWNERS
extensions/amp-story-interactive/OWNERS

Hey @processprocess! These files were changed:

extensions/amp-story-360/OWNERS
extensions/amp-story-panning-media/OWNERS

Hey @t0mg! These files were changed:

extensions/amp-story-360/OWNERS

Hey @newmuis! These files were changed:

extensions/amp-story-panning-media/OWNERS
extensions/amp-story-player/OWNERS
extensions/amp-story/OWNERS

Hey @Enriqe! These files were changed:

extensions/amp-story-player/OWNERS
extensions/amp-story/OWNERS
src/amp-story-player/OWNERS

Hey @wassgha! These files were changed:

testing/amp-performance-extension/OWNERS

Hey @ampproject/wg-caching! These files were changed:

validator/OWNERS

Copy link
Member

@danielrozenberg danielrozenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking comment per @rsimha's request

@rsimha
Copy link
Contributor Author

rsimha commented Apr 7, 2021

Update: ampproject/amp-github-apps#1256 has been merged, and the default branch of amp-github-apps has been renamed.

This PR can be merged now. @jridgewell @kristoferbaxter Could I get a top-level owners approval from one of you? And @danielrozenberg, could I get an Infra-team approval from you?

Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rubber-stamp:

@rsimha rsimha dismissed danielrozenberg’s stale review April 7, 2021 21:34

The branch has been renamed, and this PR is now safe to merge.

@rsimha rsimha merged commit 730e285 into ampproject:master Apr 7, 2021
@rsimha rsimha deleted the 2021-03-31-MasterBranchLinksAGA branch April 7, 2021 21:34
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants