Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Page attachments] [Inline] Open to max of 80% of screen #32760

Closed
processprocess opened this issue Feb 19, 2021 · 7 comments · Fixed by #33423
Closed

[Page attachments] [Inline] Open to max of 80% of screen #32760

processprocess opened this issue Feb 19, 2021 · 7 comments · Fixed by #33423

Comments

@processprocess
Copy link
Contributor

processprocess commented Feb 19, 2021

Open to max of 80% of screen.
Open to size of content if less than 80%.

Tapping the story in background should dismiss the attachment.

Scrolling the content will open it to 100%.

Screen Shot 2021-02-19 at 4 47 59 PM

Screen Shot 2021-02-19 at 4 48 35 PM

@ampproject/wg-stories

@nterol
Copy link

nterol commented Mar 17, 2021

Will it be still possible to open the attachment to 100% of screen ?

@processprocess
Copy link
Contributor Author

Will it be still possible to open the attachment to 100% of screen ?

Hi @nterol :)
Yes, swiping up will open the attachment to 100%

@nterol
Copy link

nterol commented Mar 17, 2021

Will it be still possible to open the attachment to 100% of screen ?

Hi @nterol :)
Yes, swiping up will open the attachment to 100%

Thank you for your answer

Do you mean this will be the default behavior of the page attachment once this PR is merged ? Or will it be a behavior one can choose ?

@processprocess
Copy link
Contributor Author

For sure!
It will be default, like the bookend but it will have a close button at the top as an additional dismissal affordance.
Mar-17-2021 10-27-39

We're making this change to give users additional context that they are still viewing content within a story.

@nterol
Copy link

nterol commented Mar 17, 2021

So there will not be a possibility to skip this 80% preview then.

I'm asking this because I'm currently doing the opposite : I'm forcing the attachment to show a 10~20% preview so that users understand the attachment is present, and can then be extended to 100%.

@newmuis newmuis assigned processprocess and unassigned raxsha Mar 17, 2021
@processprocess
Copy link
Contributor Author

@nterol thanks for the feedback and sharing this concept.
It's an interesting idea to display a preview of the attachment content.

Currently taps on page attachments block navigation.
Page navigation is core UX of the experience and we need to prioritize it.

I'd be happy to see explorations/examples of this concept.
I'm on the AMP slack channel btw, feel free to ping me any time!

@nterol
Copy link

nterol commented Mar 22, 2021

Thank you for your answer, let's keep in touch on slack then !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants