✨ [amp-story] [inline-page-attachments] Open to max of 80% #33423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed: |
|
Thank you for posting a demo! |
mszylkowski
reviewed
Mar 23, 2021
mszylkowski
reviewed
Mar 24, 2021
mszylkowski
approved these changes
Mar 24, 2021
gmajoulet
reviewed
Mar 24, 2021
gmajoulet
reviewed
Mar 24, 2021
processprocess
force-pushed
the
80-percent
branch
from
2d94f74
to
93cf84a
Compare
gmajoulet
approved these changes
Mar 25, 2021
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
…t#33423) * Basic implementation. * Calc using page height var * Lint fixes. Update template and css. * Check if parent is page attachment. * Offset open drag by spacer element height. * Update comment * Update comment. * Use resizeObserver to get reference to spacer ehight. * Css and querySelecotors. * CSS targetting.g * Reset scroll position after close transition. * Specify close handler. * Adjust overlay opacity. * Use closest method. * Remove css. * Mark scrollTop as OK. * Update all draggable drawers. * Fix merge conflict. * Fix merge conflict. * Fix merge conflict. * rebase * Remove getPage, remove repeated CSS. * revert z-index * Subscribe only if in experiment. * Lint fix * Update z-index * Use insertBefore instead of prepend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edits apply to mobile view only.
Context / Fixes #32760 & #32761
All edits are hidden behind the
amp-story-page-attachment-ui-v2flagdemo pages 1 and 2.
Copy paste the following in the console of the demo page to turn the experiment on:
AMP.toggleExperiment('amp-story-page-attachment-ui-v2');