Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ampproject/amphtml] ♿ [Story a11y] Empty img alt tags #32880

Merged
merged 3 commits into from
Feb 25, 2021

Conversation

processprocess
Copy link
Contributor

Contributes to #32493

Sets completely empty alt tag on images by default.

@amp-owners-bot
Copy link

Hey @gmajoulet, @newmuis, @Enriqe! These files were changed:

extensions/amp-story/1.0/amp-story-page.js

Copy link
Contributor

@mszylkowski mszylkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you want to merge the space removal

@processprocess processprocess merged commit 02ca8f4 into ampproject:master Feb 25, 2021
@processprocess processprocess deleted the image-alt branch February 25, 2021 15:16
@gmajoulet
Copy link
Contributor

cc @caroqliu FYI as I know you've built a lot of experience with how screen readers use empty strings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants