Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Page attachments] [Outlink] Anchor link for bot rendering. #34015

Open
processprocess opened this issue Apr 26, 2021 · 1 comment
Open

[Page attachments] [Outlink] Anchor link for bot rendering. #34015

processprocess opened this issue Apr 26, 2021 · 1 comment

Comments

@processprocess
Copy link
Contributor

The CTA is now an anchor element so the remote-content element does not need to be:

<a class="i-amphtml-story-page-attachment-remote-content" target="_blank">
<span class="i-amphtml-story-page-attachment-remote-img" ref="remoteImgEl"></span>
<span class="i-amphtml-story-page-attachment-remote-title"><span ref="openStringEl"></span><span ref="urlStringEl"></span></span>
<svg class="i-amphtml-story-page-attachment-remote-icon" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 48 48"><path d="M38 38H10V10h14V6H10c-2.21 0-4 1.79-4 4v28c0 2.21 1.79 4 4 4h28c2.21 0 4-1.79 4-4V24h-4v14zM28 6v4h7.17L15.51 29.66l2.83 2.83L38 12.83V20h4V6H28z"/></svg>
</a>`;

This was originally done for bot rendering when the CTA was not an anchor element.

When converting this to a div we will need to confirm that bots will be able to crawl the anchor link on the CTA button.

Currently the CTA button is not rendered in vertical mode.
We might need to render the outlink CTAs to be sure they are crawled by bots.
Screen Shot 2021-04-26 at 1 48 23 PM

Instructions to set up a custom device in chrome devtools for debugging bot rendering:
unnamed

User agent string:
Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)

@ampproject/wg-stories

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant