Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Amp story][Page attachments] Render V2 attachment CTA buttons for bot rendering #34197

Closed
wants to merge 2 commits into from

Conversation

processprocess
Copy link
Contributor

Context / Fixes #34015

For V2 attachment CTA buttons.

  • Renders all CTA buttons instead of page attachments.

Screen Shot 2021-05-04 at 11 26 58 AM

@amp-owners-bot
Copy link

amp-owners-bot bot commented May 4, 2021

Hey @gmajoulet, @newmuis, @Enriqe! These files were changed:

extensions/amp-story/1.0/amp-story-open-page-attachment.css
extensions/amp-story/1.0/amp-story-page-attachment.js
extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/amp-story-vertical.css
extensions/amp-story/1.0/amp-story.js

@gmajoulet
Copy link
Contributor

What's the status of this PR? Do we need to update/merge it?

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Sep 21, 2022
@stale stale bot closed this Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Inactive for one year or more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Page attachments] [Outlink] Anchor link for bot rendering.
2 participants