-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mechanism for selecting image file based on capability #3517
Comments
Slotting in Backlog to start, but please feel free to update if the milestone is different or changes |
I'd like to consider a more general element, e.g. |
@dvoytenko that seems |
It would also be nice if this would work in all image scenarios, such as |
We encountered some trouble trying to take the art-direction approach for selecting images in an |
@eike-hass To clarify, do you mean In particular:
Layout-wise, most of what Depending on how you source images for your carousel, you can always pick the best aspect ratio and use |
@dvoytenko thank you for the information. We were able solve many of our challenges. Especially the |
Yes, let's definitely discuss it in a separate thread. |
@Gregable is this still a valid request? Thanks |
@ericlindley-g to decide if we still need this. Thanks |
@adelinamart , it's still a valid request. I don't know if it's a priority. |
I've come across this issue building a static site using Jekyll. Since AMP is designed for static sites, this fix would require amp-img support to run some sort of JS polyfill for browsers that lack support. There is no other way around this. Please, no more hacks. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
I think this is still a reasonable request. Publishers should be able to select between image formats based on capability. |
I'll add that |
I want to lend my support to this. We need to support the picture tag, or an equivalent of it. This is a big shortcoming in AMP to date (and the workarounds with the |
I agree this should be supported. My preference would be to support the native |
WebP images are not supported on all browsers, but can be enabled per browser as a means of reducing bytes on the wire.
In the case of the AMP Cache, the origin can't respond selectively with different image types based on the browser request headers, so the decision of image variant would need to be something the browser selects.
With a
<picture>
tag, this is possible outside of AMP, ie:However, AMP doesn't seem to have anything similar with
<amp-img>
.The text was updated successfully, but these errors were encountered: