-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow picture element in noscript tag #18965
Comments
SGTM /to @Gregable |
SGTM too. In the meantime, I believe you can accomplish the same thing on a single img tag using srcset and sizes attributes. |
Actually @aghassemi , is there a reason we couldn't allow something similar for
Does this work? What would we need to do to make it work? It would address #3517 as well. |
This is incorrect, I didn't initially realize you were doing this to select webp. As an aside, your top |
OK, so what is correct solution for support non-webp browser? There is same sample in the documentation https://www.ampproject.org/docs/design/responsive/responsive_design#providing-optimized-images maybe it should change or it should be mentioned there. |
Ah, I didn't realize that this was being recommended. It's the only solution that works today that I know of, I'm just hoping @aghassemi or someone else has ideas for making this better. |
Resolves the noscript parts of #18965
Resolves the noscript parts of #18965
yes, we essentailyl cover |
Resolves the noscript parts of ampproject#18965
Resolves the noscript parts of ampproject#18965
this is linked to the issue 1279
Now is allowed have
<img>
,<video>
, and<audio>
in<noscript>
. It'll be nice to have some way how to create a fallback for webp format when user didn't have javascript allowed. I think it should also be allowed to have<picture>
element in<noscript>
.There is a simple example:
The text was updated successfully, but these errors were encountered: