Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests that became flaky on CircleCI with the move to Docker containers #35241

Open
danielrozenberg opened this issue Jul 15, 2021 · 2 comments

Comments

@danielrozenberg
Copy link
Member

The following tests have become flaky and were disabled with the move from VMs to Docker containers in #35176:

  • amp carousel:0.2 in lightbox chrome Standalone environment should open with both arrows (broken assertion)
  • amp carousel:0.2 in lightbox chrome Standalone environment should open with one arrow (broken assertion)
  • amp-story-auto-ads:basic chrome Standalone environment should render correctly (broken assertion)
  • amp-story-auto-ads:fullbleed chrome Standalone environment should render correctly (broken assertion)
  • [v0.1] amp-base-carousel - mixed length slides chrome Standalone environment snap should snap on the center point (broken assertion)
  • [v0.1] amp-base-carousel - snap property chrome Standalone environment should set snap property on spacers (broken assertion)
  • [v1.0] amp-base-carousel - responsive attributes chrome Standalone environment should layout correctly after resize (timeout)
  • [v1.0] amp-base-carousel - responsive attributes chrome Standalone environment should layout correctly initially (timeout)
  • [v1.0] amp-base-carousel - responsive attributes chrome Standalone environment should respond to attribute changes (timeout)
  • [v1.0] amp-base-carousel - responsive attributes chrome Standalone environment should retain position when changing the visible count (timeout)
  • [v1.0] amp-social-share chrome Standalone environment rendering renders the default social share button (timeout)
  • [v1.0] amp-social-share chrome Standalone environment rendering renders the social share button with custom sizing (timeout)
  • [v1.0] amp-social-share chrome Standalone environment rendering renders the social share button with custom type and endpoint (timeout)
@danielrozenberg
Copy link
Member Author

Assigning to @alanorozco who approved disabling the flaky tests - please reassign this to whoever you think should be fixing these :)

@stale
Copy link

stale bot commented Oct 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment